Skip to content

tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accuracy #13174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accuracy #13174

merged 1 commit into from
Jul 1, 2020

Conversation

@jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Jun 23, 2020

Summary of changes

tests-mbed_timing_fpga_ci_test_shield-watchdog is sometimes failed with some boards.

Proposition is to use information from hal_watchdog_get_platform_features api
like for
https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbed_hal/watchdog_timing/main.cpp

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant jeromecoutant changed the title tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accuray tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accuracy Jun 23, 2020
@ciarmcom ciarmcom requested a review from a team June 23, 2020 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 23, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate in the commit message about what is this fixing ?

I assume timeout_ms was a given number that would be upscaled to fit most of the platforms. This was failing some slower targets? Thus using frequency (where is this coming from, config?).

My proposal would be to have details in the commit message so we do not need to read the code to find out where all these numbers come from and how they fix the issue (timeout_ms vs accuracy).

@ciarmcom ciarmcom requested a review from a team June 23, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 23, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jeromecoutant
tests-mbed_timing_fpga_ci_test_shield-watchdog update with clock accu…
4d7db01 
…racy information

Test is checking the exact time for watchdog,
which is based on a non accurate clock...

Correction is then taken into account clock information from API.
@jeromecoutant
Copy link
Collaborator Author

jeromecoutant commented Jun 24, 2020

Can you elaborate in the commit message about what is this fixing ?

done

@mergify mergify bot added needs: CI and removed needs: review labels Jun 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 25, 2020
@0xc0170 0xc0170 merged commit 76831a9 into ARMmbed:master Jul 1, 2020
@mergify mergify bot removed the ready for merge label Jul 1, 2020
@jeromecoutant jeromecoutant deleted the PR_FPGA_WATCHDOG branch July 1, 2020 11:52
@adbridge adbridge added release-version: 6.2.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees

No one assigned

Labels

release-version: 6.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @adbridge